feat(nav): Open zendesk when clicking 'contact support' #86068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
approved these changes
Mar 4, 2025
| label: t('Contact Support'), | ||
| externalHref: `mailto:${ConfigStore.get('supportEmail')}`, | ||
| }, | ||
| ...(contactSupportItem ? [contactSupportItem] : []), |
There was a problem hiding this comment.
I think the menuItemProp supports a disabled prop for this use case — I also used to use this ternary + destructuring combo for the issue view nav, but I think the disabled prop should achieve the same behavior.
There was a problem hiding this comment.
Yeah it does support disabled, but I don't want this to show up at all if you're self hosted and don't have a support email in the config
There was a problem hiding this comment.
Oh my b I meant hidden. but now that I think about it, you'll still have to destructure the contactSupportItem anyways, so this might not make it much cleaner
There was a problem hiding this comment.
Ohh I didn't actually know about that property!
Bundle ReportChanges will decrease total bundle size by 6.0kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the old behavior where in SaaS we would open the zendesk widget when clicking "contact support". We can't use the existing ZendeskLink component because we need to specify the dropdown menu item as an object, so I extracted some logic out to a util file.